Add support for embedded _id in documentdb - #385
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughOverhauls BSON value comparison to a centralized, type-ordered comparator (handles numeric edge cases including Decimal128/NaN/±Inf, strings, binary, documents, arrays, timestamps, regex, JS code, null/min/max keys) and expands supported DocumentDB ChangesBSON Comparison Infrastructure
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@connectors/mongo/docdb_sort_external_test.go`:
- Around line 31-33: The test currently always uses and drops the fixed
collection "dsync_sort_test.embedded_ids" (see
client.Database(...).Collection(...) and col.Drop(ctx)), which can cause
cross-run interference; change to derive the collection name from t.Name() plus
a unique suffix (e.g., a timestamp or random hex) and use that when calling
client.Database("dsync_sort_test").Collection(collName); assign the collection
to col and register a cleanup via t.Cleanup(func() { require.NoError(t,
col.Drop(ctx)) }) so the collection is removed after the test, and replace the
immediate require.NoError(t, col.Drop(ctx)) call with the cleanup to avoid
clobbering other runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6ac0f91a-bd69-4c4e-9e89-0f209e2fe963
📒 Files selected for processing (3)
connectors/mongo/docdb.goconnectors/mongo/docdb_sort_external_test.goconnectors/mongo/docdb_test.go
adiom-mark
force-pushed
the
docdbembedded
branch
from
June 12, 2026 16:47
61a1d7a to
29fa1f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests